Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-922: Improve automatic runtimeUpgrade debug capabilities #1431

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

atodorov
Copy link
Contributor

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@atodorov atodorov marked this pull request as draft November 28, 2023 14:56
@atodorov atodorov changed the title Improve automatic runtimeUpgrade debug capabilities CSUB-922: Improve automatic runtimeUpgrade debug capabilities Nov 30, 2023
The URL itself is public and when it is NOT specified as a
repository secret we can actually see it in the logs which helps with
debugging in case something fails or is suspected of failure.

Rename the key variable for readability.
b/c I want to retrigger Devnet upgrade once merged
@atodorov atodorov force-pushed the testing/improve-automatic-runtimeUpgrade branch from e9d4774 to 3c6be94 Compare November 30, 2023 11:59
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a8314df) 70.64% compared to head (3c6be94) 71.66%.

❗ Current head 3c6be94 differs from pull request most recent head 2f96260. Consider uploading reports for the commit 2f96260 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1431      +/-   ##
==========================================
+ Coverage   70.64%   71.66%   +1.02%     
==========================================
  Files         111      111              
  Lines       13009    13009              
  Branches      128      128              
==========================================
+ Hits         9190     9323     +133     
+ Misses       3819     3676     -143     
- Partials        0       10      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

For full LLVM coverage report click here!

@atodorov atodorov marked this pull request as ready for review November 30, 2023 12:51
@atodorov atodorov requested review from nathanwhit and removed request for wahid-gluwa November 30, 2023 15:26
@atodorov atodorov merged commit eebe47b into dev Nov 30, 2023
@atodorov atodorov deleted the testing/improve-automatic-runtimeUpgrade branch November 30, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants