Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert hard-coded version to regex to appease MegaLinter #1417

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Nov 1, 2023

to avoid using the exact version string b/c it changes from time to time

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

to avoid using the exact version string b/c it changes from time to time
Copy link

github-actions bot commented Nov 1, 2023

For full LLVM coverage report click here!

@codecov-commenter
Copy link

Codecov Report

Merging #1417 (30830c0) into dev (d9373cd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1417   +/-   ##
=======================================
  Coverage   26.97%   26.97%           
=======================================
  Files          31       31           
  Lines        1001     1001           
  Branches      128      128           
=======================================
  Hits          270      270           
  Misses        721      721           
  Partials       10       10           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atodorov atodorov merged commit 02a1e6a into dev Nov 6, 2023
36 of 37 checks passed
@atodorov atodorov deleted the fix-megalinter-issues branch November 6, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants