Try fixing test against fork CI job #1388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a4b04d8 to
de7dd11
Compare
Codecov Report
@@ Coverage Diff @@
## main #1388 +/- ##
=======================================
Coverage 72.08% 72.08%
=======================================
Files 110 110
Lines 12873 12873
Branches 120 120
=======================================
Hits 9280 9280
Misses 3583 3583
Partials 10 10 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
For full LLVM coverage report click here! |
f93d863 to
5270be9
Compare
atodorov
reviewed
Nov 1, 2023
| @@ -214,7 +215,7 @@ jobs: | |||
|
|
|||
| ./creditcoin-fork --bin ./creditcoin-node --orig ${{ needs.setup.outputs.target_chain }} \ | |||
| --base dev --name Development \ | |||
| -o creditcoin-fork.json --rpc ws://127.0.0.1:9944 | |||
| -o creditcoin-fork.json --rpc ws://127.0.0.1:9944 --exclude-pallets PosSwitch | |||
There was a problem hiding this comment.
Q: Why exclude the PosSwitch pallet ? What's the reasoning here?
fd523a8 to
4a36d86
Compare
atodorov
reviewed
Nov 8, 2023
There was a problem hiding this comment.
Test agaonst fork passed here: https://github.com/gluwa/creditcoin/actions/runs/6801923257/job/18497475426?pr=1388
LGTM, but still have a question here https://github.com/gluwa/creditcoin/pull/1388/files#r1378496415
|
Merged in #1430. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Practical tips for PR review & merge: