Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSUB-874] Update bag thresholds #1383

Merged
merged 8 commits into from
Nov 6, 2023
Merged

[CSUB-874] Update bag thresholds #1383

merged 8 commits into from
Nov 6, 2023

Conversation

nathanwhit
Copy link
Contributor

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

Merging #1383 (debeb40) into dev (d9373cd) will decrease coverage by 0.15%.
The diff coverage is 3.33%.

@@            Coverage Diff             @@
##              dev    #1383      +/-   ##
==========================================
- Coverage   72.00%   71.86%   -0.15%     
==========================================
  Files         110      111       +1     
  Lines       12926    12953      +27     
  Branches      128      128              
==========================================
+ Hits         9308     9309       +1     
- Misses       3608     3634      +26     
  Partials       10       10              
Files Coverage Δ
runtime/src/version.rs 0.00% <ø> (ø)
runtime/src/lib.rs 16.77% <0.00%> (-0.46%) ⬇️
runtime/generate-bags/src/main.rs 5.26% <5.26%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

runtime/generate-bags/Cargo.toml Show resolved Hide resolved
runtime/src/version.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Show resolved Hide resolved
@AdaJane
Copy link
Contributor

AdaJane commented Oct 27, 2023

@nathanwhit Can you summarize the expected impact on the existing nominators? What happens when we release this update?

@nathanwhit nathanwhit force-pushed the bag-thresholds-update branch from 8a6bd6b to 356afa2 Compare November 1, 2023 21:12
Copy link

github-actions bot commented Nov 1, 2023

For full LLVM coverage report click here!

@nathanwhit
Copy link
Contributor Author

@nathanwhit Can you summarize the expected impact on the existing nominators? What happens when we release this update?

The existing nominators will be partitioned into the new bags via the migration that runs on the runtime upgrade. I've simulated it on a local network to make sure that it behaves as expected, and that it completes in a reasonable amount of time (I tested with ~30000 nominators and it didn't impact block time or anything).

@atodorov atodorov force-pushed the bag-thresholds-update branch from debeb40 to 11001d7 Compare November 6, 2023 13:49
Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased. LGTM.

@atodorov atodorov merged commit 03b6b95 into dev Nov 6, 2023
36 of 37 checks passed
@atodorov atodorov deleted the bag-thresholds-update branch November 6, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants