-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSUB-874] Update bag thresholds #1383
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1383 +/- ##
==========================================
- Coverage 72.00% 71.86% -0.15%
==========================================
Files 110 111 +1
Lines 12926 12953 +27
Branches 128 128
==========================================
+ Hits 9308 9309 +1
- Misses 3608 3634 +26
Partials 10 10
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@nathanwhit Can you summarize the expected impact on the existing nominators? What happens when we release this update? |
8a6bd6b
to
356afa2
Compare
For full LLVM coverage report click here! |
The existing nominators will be partitioned into the new bags via the migration that runs on the runtime upgrade. I've simulated it on a local network to make sure that it behaves as expected, and that it completes in a reasonable amount of time (I tested with ~30000 nominators and it didn't impact block time or anything). |
debeb40
to
11001d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased. LGTM.
Description of proposed changes
Practical tips for PR review & merge: