Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-852: Update System.remark weights #1381

Merged
merged 3 commits into from
Oct 18, 2023
Merged

CSUB-852: Update System.remark weights #1381

merged 3 commits into from
Oct 18, 2023

Conversation

zacharyfrederick
Copy link
Contributor

I think this is the proper way to do this.

In csub-819 it was decided that 0.0000000015 CTC = 1 Byte.

0.0000000015 * 10^18 (credo) = 1_500_000_000

To go from Length to weight use a constant multiplier of 1_500_000_000. Previously it was a 1:1 mapping using a 1st degree polynomial

@zacharyfrederick zacharyfrederick marked this pull request as ready for review October 13, 2023 18:08
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Merging #1381 (e833c82) into dev (1e9eade) will increase coverage by 56.30%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              dev    #1381       +/-   ##
===========================================
+ Coverage   13.68%   69.98%   +56.30%     
===========================================
  Files          31      107       +76     
  Lines        1001    12559    +11558     
  Branches      128      128               
===========================================
+ Hits          137     8790     +8653     
- Misses        864     3769     +2905     
Files Coverage Δ
runtime/src/lib.rs 17.00% <ø> (ø)
runtime/src/version.rs 0.00% <ø> (ø)

... and 74 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

runtime/src/lib.rs Show resolved Hide resolved
@zacharyfrederick zacharyfrederick merged commit a5e540d into dev Oct 18, 2023
@zacharyfrederick zacharyfrederick deleted the csub-852 branch October 18, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants