Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MegaLinter issues #1380

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Fix MegaLinter issues #1380

merged 3 commits into from
Oct 23, 2023

Conversation

atodorov
Copy link
Contributor

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

Merging #1380 (492cedf) into dev (a5e540d) will decrease coverage by 4.88%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1380      +/-   ##
==========================================
- Coverage   74.86%   69.98%   -4.88%     
==========================================
  Files          76      107      +31     
  Lines       11558    12559    +1001     
  Branches        0      128     +128     
==========================================
+ Hits         8653     8790     +137     
- Misses       2905     3769     +864     

see 31 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

I find myself copying these commands too often and adding --base-path
makes things a bit easier.
@atodorov atodorov force-pushed the fix/megalinter-issues branch from c81b74c to 492cedf Compare October 23, 2023 09:54
@github-actions
Copy link

For full LLVM coverage report click here!

@atodorov atodorov merged commit 011291d into dev Oct 23, 2023
@atodorov atodorov deleted the fix/megalinter-issues branch October 23, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants