Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testnet 2.222.2 #1161

Merged
merged 83 commits into from
Jun 26, 2023
Merged

Update testnet 2.222.2 #1161

merged 83 commits into from
Jun 26, 2023

Conversation

AdaJane
Copy link
Contributor

@AdaJane AdaJane commented Jun 26, 2023

Description of proposed changes

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

atodorov and others added 30 commits June 19, 2023 11:57
@atodorov
Update build script, make it the same as creditcoin-js
faadf01 
otherwise I was getting the following error:

$ yarn build
yarn run v1.22.19
$ npx tsc
/bin/sh: 1: npx: not found
@atodorov
Reorder cc-cli commands alphabetically
e113da2 
b/c that affects the order in which commands are printed in help text
@atodorov
Auto-update creditcoin-js type definitions
d1d895b
@ESPINS @atodorov
fix parseRewardDestination
efce835
@pLabarta @atodorov
docs: add bootnodes and chainspec info
a362264
@pLabarta @atodorov
Add network table
174a29b
@pLabarta @atodorov
Remove "Transaction fees" row
149ffe7 
Not actually true. There are fees, but tokens should be free to acquire.
@pLabarta @atodorov
fix: remove pkg version warnings
0f395d0
@pLabarta @atodorov
add: change confirmations to using prompts
c6bd1b3
@atodorov @AdaJane
cc-cli: Exit with non-zero in case of errors
8dd8218
@atodorov
Update network description for PoS Testnet in test config
7d93fcf
@atodorov
cc-cli: Remove bondExtra command in favor of bond --extra
9f2771e
@atodorov
Remove utils/bondExtra b/c unused by anything else
bef494e
@atodorov
Fix typo b/c this migration changed name
f2f16fc
@atodorov
Remove the Build sections from README
df30f76 
Building is described in details in `Dependency Setup` section anyway
@atodorov
Remove duplicate link
0cae358
@atodorov
Update Legacy section to say 1.x
7b5901c 
because soon enough 2.0 PoW will also be legacy

and remove a 404 URL for pre-2.0-mining-setup
@atodorov
Remove old docker-compose.yml file
c30dca0 
it doesn't seem to be used anywhere and also looks like a build compose,
not an example of how creditcoin-node should be run
@atodorov
Add docker-compose.yml example with bind-mounted directory
28b33f4 
Note: testnet chain spec already specifies boot node so no need to
hard-code it here
@atodorov
Make sure /creditcoin-node/data is present inside the container
587bd5b
@atodorov
Add a test job for persistently mounted docker volume
2ff9927
@atodorov
ci: Remaove redundant -v argument for docker run
a63480f 
this only make sense if we specify --base-path, which we do in the next
section
@pLabarta @AdaJane
cc-cli: Add --use-ecdsa flag for the send command
b23422d
@jonZlotnik
CSUB-589: changed sensitive input to interactive or env vars (#1151)
6dc67c3 
* changed sensitive input to interactive or env vars

* improved error handling in getSeedFromEnvOrPrompt

* yarn format

* eslint

* changed prompt from invisible to password

* centralized the regular seed

* rectified stash vs bond key elicitation

* set_keys actor rectification

* make pretty

* unbound to controller seed

* appropriate names

* prettify

---------

Co-authored-by: Jon Zlotnik <jon.zlotnik@gluwa.com>
@atodorov @AdaJane
Update help text in distributeRewards command to make it more obvious
d7bc3eb
@pLabarta @atodorov
add: status command uses new util
19b0c3d
@pLabarta @atodorov
add: chill checks if validating
08f0689
@pLabarta @atodorov
fix: query errors & types
469397b
@pLabarta @atodorov
fix: more type errors
fab132a
@pLabarta @atodorov
add: status check to chill
3d6052d
dlebee and others added 18 commits June 23, 2023 14:49
@dlebee @atodorov
brought back bin like before
bfc1325
@pre-commit-ci @atodorov
[pre-commit.ci] auto fixes from pre-commit.com hooks
2a64b39 
for more information, see https://pre-commit.ci
@AdaJane
Update versions
640496f
@AdaJane
Auto-update creditcoin-js type definitions
4809b22
@AdaJane
Whitespace change to trigger CI with gluwa-bot updates
fb4474e
@pre-commit-ci @AdaJane
[pre-commit.ci] auto fixes from pre-commit.com hooks
8a64565 
for more information, see https://pre-commit.ci
@atodorov @AdaJane
Remove a leftover TODO comment
c52e366
@atodorov @AdaJane
Remove leading spaces in wizard's console.log
5d565a1 
otherwise the output looks weird in my terminal
@dlebee @atodorov
that should do the trick.
cc0cf61
@dlebee @atodorov
linter
9182153
@dlebee @atodorov
prettier
482e295
@dlebee @atodorov
fixed that its 2CTC instead of 2WEI CTC.
fe425c7
@dlebee @atodorov
fixing the message the CTC should be formatted well now.
c87105d
@dlebee @atodorov
yay format is happy now.
5318636
@dlebee @atodorov
will report block in which an error as occured
c081a2f
@dlebee @atodorov
include the block hash it failed at.
a5b3ba5
@dlebee @atodorov
happy now format :D
181b1d0
@AdaJane
Merge branch 'testnet' into update-testnet-2.222.2
61d5421
@AdaJane AdaJane marked this pull request as ready for review June 26, 2023 13:52
@github-actions
Copy link

For full LLVM coverage report click here!

nathanwhit
nathanwhit previously approved these changes Jun 26, 2023
View reviewed changes
@atodorov
ci: When running the forked network make sure to run as validator
a6dedde 
b/c now we've switched Testnet to PoS and the local node running the
fork doesn't produce any blocks.
@AdaJane AdaJane merged commit 7a6f5ca into testnet Jun 26, 2023
@AdaJane AdaJane deleted the update-testnet-2.222.2 branch June 26, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

@dlebee dlebee dlebee approved these changes

@atodorov atodorov Awaiting requested review from atodorov

@zacharyfrederick zacharyfrederick Awaiting requested review from zacharyfrederick

@pLabarta pLabarta Awaiting requested review from pLabarta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AdaJane @nathanwhit @dlebee @atodorov @ESPINS @pLabarta @jonZlotnik