fix: Prevent infite loop when a class has a reference to a union type…

… which reference the class itself [converter]
glutinum-org · Mar 28, 2024 · 6d19aae · 6d19aae
1 parent c86a6d6
commit 6d19aae
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 3 deletions.
diff --git a/src/Glutinum.Converter/Reader/UnionTypeNode.fs b/src/Glutinum.Converter/Reader/UnionTypeNode.fs
@@ -21,7 +21,6 @@ let rec private readUnionTypeCases
         if ts.isParenthesizedTypeNode node then
             let parenthesizedTypeNode = node :?> Ts.ParenthesizedTypeNode
 
-            let i = 0
             removeParenthesizedType parenthesizedTypeNode.``type``
         else
             node
@@ -95,8 +94,23 @@ let rec private readUnionTypeCases
                     |> Some
                 else
                     let declaration = declarations.[0]
-
-                    reader.ReadNode declaration |> List.singleton |> Some
+                    // TODO: This is an optimitic approach
+                    // But we should revisit how TypeReference is handled because of recursive types
+                    match declaration.kind with
+                    | Ts.SyntaxKind.TypeAliasDeclaration ->
+                        reader.ReadNode declaration |> List.singleton |> Some
+
+                    | _ ->
+                        let fullName = checker.getFullyQualifiedName symbol
+
+                        ({
+                            Name = typeReferenceNode.getText ()
+                            FullName = fullName
+                            TypeArguments = []
+                        })
+                        |> GlueType.TypeReference
+                        |> List.singleton
+                        |> Some
 
             | None ->
                 let typ = checker.getTypeOfSymbol symbol

diff --git a/tests/specs/references/class/classWithRecursiveUnionToItself.d.ts b/tests/specs/references/class/classWithRecursiveUnionToItself.d.ts
@@ -0,0 +1,5 @@
+export declare class MyClass {
+    contains(otherBoundsOrLatLng: MyUnion | string): boolean;
+}
+
+export type MyUnion = MyClass | string;
diff --git a/tests/specs/references/class/classWithRecursiveUnionToItself.fsx b/tests/specs/references/class/classWithRecursiveUnionToItself.fsx
@@ -0,0 +1,21 @@
+module rec Glutinum
+
+open Fable.Core
+open Fable.Core.JsInterop
+open System
+
+[<Erase>]
+type Exports =
+    interface end
+
+[<AllowNullLiteral>]
+[<Interface>]
+type MyClass =
+    abstract member contains: otherBoundsOrLatLng: U2<MyUnion, string> -> bool
+
+type MyUnion =
+    U2<MyClass, string>
+
+(***)
+#r "nuget: Fable.Core"
+(***)