let the parser read content either from a file or from a file-like object #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reading and loading the WebVTT content are coupled. As a result, if the webvtt content to parse is not on the file system, we need to put it to the file system for the parser to be able to load it.
This PR decouples these 2 functions.
It keeps full backward compatibility, including for "internal" methods prefixed with
_
.With the addition of
read_buffer
method to the WebVTT class, this PR adds support for parsing any kind of file-like object: