This repository has been archived by the owner on Mar 26, 2020. It is now read-only.
Store peer address provided during peer add #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit message and PR description is ambiguous can be more clearer. You mention |
|
@prashanthpai updated commit message and PR description |
dd6b85d to
b55d6a7
Compare
|
@prashanthpai rebased |
prashanthpai
approved these changes
May 23, 2018
There was a problem hiding this comment.
LGTM 👍
I'll wait for inputs from @aravindavk too as he filed a similar issue.
aravindavk
reviewed
May 23, 2018
glusterd2/commands/peers/addpeer.go
Outdated
| //if not found prepend the remotePeerAddress to peer details | ||
| if !found { | ||
| newpeer.PeerAddresses = append([]string{remotePeerAddress}, newpeer.PeerAddresses...) | ||
| } |
There was a problem hiding this comment.
if found, we can move that address as first address in the list?
There was a problem hiding this comment.
if not found, right ?
There was a problem hiding this comment.
@prashanthpai if found, and if it's not in the index 0, we need to move it to index 0
peer add in ETCD. if peer address already present in store update configuration on startup this allows the users to use peer address provided during peer add, for any other operations(ex:- volume create,expand) Signed-off-by: Madhu Rajanna <mrajanna@redhat.com>
prashanthpai
approved these changes
May 23, 2018
aravindavk
approved these changes
May 23, 2018
|
retest this please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
store peer addresses provided during peer add in ETCD.
if peer address already present in the store
update configuration on startup
this allows the users to use peer address
provided during peer add, for any other
operations(ex:- volume create,expand)
Fixes: #725
Fixes: #758
Fixes: #724
Fixes: #721
Signed-off-by: Madhu Rajanna mrajanna@redhat.com