WIP: Intelligent Volume provisioning #513
Conversation
glusterd2/middleware/heketi.go
Outdated
|
|
||
| //if (len(req.Bricks) <= 0) && (req.Size > 0) { | ||
| if req.Size > 0 { | ||
| replacer := strings.NewReplacer("export", "testexport") |
There was a problem hiding this comment.
What is this piece of code meant for?
| Bricks []string `json:"bricks,omitempty"` | ||
| Force bool `json:"force,omitempty"` | ||
| Options map[string]string `json:"options,omitempty"` | ||
| Size int `json:"size,omitempty"` |
There was a problem hiding this comment.
Does this field represent the targetted size of volume like say 30GB or something?
There was a problem hiding this comment.
Yes, instead of mentioning the bricks we can directly provide size and then the bricks will be allocated.
| } | ||
|
|
||
|
|
||
| cmd1 := exec.Command("pvcreate", "--metadatasize=128M", "--dataalignment=256K", "/dev/"+deviceinfo.DeviceName) |
There was a problem hiding this comment.
Is pvcreate and vgcreate enough for making the device ready for brick usage?
We should create LV post this and using mkfs.xfs create a proper filesyatem. Finally mount the LV in some path to be used a bricks for the volumes.
|
|
||
| func txnHeketiCreateBrick(c transaction.TxnCtx) error { | ||
|
|
||
| return nil |
There was a problem hiding this comment.
This patch looks incomplete. Correct ?
There was a problem hiding this comment.
yes, I am still working on it
Issue:#466
TODO: