add glam feature #21
Merged
add glam feature #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alteous
reviewed
May 19, 2021
Comment on lines
+478
to
+489
| #[cfg(feature = "nalgebra")] | ||
| let mut vOs = (*pTriInfos.offset(f as isize)).vOs | ||
| - (n.dot(&(*pTriInfos.offset(f as isize)).vOs) * n); | ||
| vOt = (*pTriInfos.offset(f as isize)).vOt | ||
| #[cfg(feature = "nalgebra")] | ||
| let mut vOt = (*pTriInfos.offset(f as isize)).vOt | ||
| - (n.dot(&(*pTriInfos.offset(f as isize)).vOt) * n); | ||
| #[cfg(feature = "glam")] | ||
| let mut vOs = (*pTriInfos.offset(f as isize)).vOs | ||
| - (n.dot((*pTriInfos.offset(f as isize)).vOs) * n); | ||
| #[cfg(feature = "glam")] | ||
| let mut vOt = (*pTriInfos.offset(f as isize)).vOt | ||
| - (n.dot((*pTriInfos.offset(f as isize)).vOt) * n); |
There was a problem hiding this comment.
These lines look identical to me. Am I missing something?
There was a problem hiding this comment.
I believe the nalgebra version needed to borrow the parameter of the n.dot(..) function.
|
Of course :) |
|
The build seems to be broken and CI is no longer working. I need to confirm the library is working before I release a new version. |
|
Following up on this, did you confirm whether this was fixed or not? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
glamfeature which uses the glam crate instead ofnalgebrato reduce the amount of dependencies for crates not usingnalgebra(specifically the bevy engine).Let me know if this is something you'd merge, otherwise if it is okay if I fork this repo and publish it using glam (#20).