🧹 Remove redundant backsweep flag from GaussianActivationParameters #1423
Conversation
|
|
|
There was a problem hiding this comment.
PR Type: Refactoring
PR Summary: The pull request removes the 'backsweep' boolean flag from various components related to Gaussian activation in the codebase. This change simplifies the parameter model by eliminating the need for a flag that was previously used as user input in older versions of the system.
Decision: Comment
📝 Type: 'Refactoring' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Ensure that the removal of the 'backsweep' flag and the associated changes do not introduce any division by zero errors, especially when 'backsweep_period' is zero.
- Verify that the removal of the 'type:ignore[operator]' comment does not lead to any unresolved type issues or introduce new ones.
- Review all parts of the codebase that interact with the modified functions and classes to confirm that they are compatible with the updated function signatures and class attributes.
- Consider the broader impact of these changes on the system's behavior, particularly in cases where the 'backsweep' condition was previously used to guard against certain calculations.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## staging #1423 +/- ##
=========================================
- Coverage 84.9% 84.9% -0.1%
=========================================
Files 91 91
Lines 3746 3744 -2
Branches 728 728
=========================================
- Hits 3182 3180 -2
Misses 450 450
Partials 114 114 ☔ View full report in Codecov by Sentry. |
…lotaran#1423) Just a small additional clean-up after glotaran#1422 to get rid of the backsweep boolean flag, which is a residual of the < 0.8 model syntax when we had this as user input.
Just a small additional clean-up after #1422 to get rid of the
backsweepboolean flag, which is a residual of the< 0.8model syntax when we had this as user input.Change summary
Checklist