Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹Fix for when the backsweep is a parameter rather than constant #1422

Merged
merged 5 commits into from
Jan 27, 2024
Merged

🩹Fix for when the backsweep is a parameter rather than constant #1422

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
91fde44
Fix for when the backsweep is a parameter rather than constant
jsnel Jan 27, 2024
3490e52
👌Simplify the fix as per reviewer suggestions
jsnel Jan 27, 2024
b788092
Revert "👌Simplify the fix as per reviewer suggestions"
jsnel Jan 27, 2024
b2df4f7
Reapply "👌Simplify the fix as per reviewer suggestions"
s-weigand Jan 27, 2024
3c4b3d2
🧹 Use `self.backsweep` instead of `backsweep` for condition
s-weigand Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions glotaran/builtin/items/activation/gaussian.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,15 +171,15 @@ def parameters(

scales = self.scale or [1.0] * nr_gaussians
backsweep = self.backsweep is not None
backsweep_period = self.backsweep if backsweep else 0
backsweep_period = float(self.backsweep) if self.backsweep is not None else 0

parameters: list[GaussianActivationParameters] = [
GaussianActivationParameters(
float(center),
float(width),
float(scale),
backsweep,
backsweep_period, # type:ignore[arg-type]
backsweep_period,
)
for center, width, scale in zip(centers, widths, scales)
]
Expand Down
Loading