Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Change Parameter from attrs to pydantic #1381

Merged
merged 3 commits into from
Oct 22, 2023
Merged

♻️ Change Parameter from attrs to pydantic #1381

merged 3 commits into from
Oct 22, 2023

Conversation

s-weigand
Copy link
Member

No need to have attrs and pydantic at the same time.

@s-weigand s-weigand requested review from a team, jsnel and joernweissenborn as code owners October 21, 2023 21:23
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/pydantic_parameters

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 21, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
glotaran/parameter/parameter.py 85.1% <100.0%> (-0.1%) ⬇️
glotaran/parameter/parameters.py 94.2% <100.0%> (ø)
glotaran/model/item.py 90.8% <50.0%> (ø)

📢 Thoughts on this report? Let us know!.

jsnel
jsnel approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That cleans up nicely! LGTM!

joernweissenborn
joernweissenborn reviewed Oct 21, 2023
View reviewed changes
Copy link
Member

@joernweissenborn joernweissenborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Huge thx to you @s-weigand

@s-weigand s-weigand mentioned this pull request Oct 21, 2023
Merged
@jsnel
Copy link
Member

jsnel commented Oct 22, 2023

Tested ok, tests are running, the two ported case studies are running.

@jsnel jsnel merged commit af9b42c into glotaran:staging Oct 22, 2023
@jsnel jsnel deleted the pydantic_parameters branch October 22, 2023 06:16
jsnel pushed a commit to jsnel/pyglotaran that referenced this pull request Jun 2, 2024
@s-weigand @jsnel
♻️ Change Parameter from attrs to pydantic (glotaran#1381)
55278a6 
* ♻️ Change Parameter from attrs to pydantic

* 🧹 Change .copy to .model_copy

* 🧹 Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joernweissenborn joernweissenborn joernweissenborn approved these changes

@jsnel jsnel jsnel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s-weigand @jsnel @joernweissenborn