Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clp constraints #1366

Merged
merged 6 commits into from
Oct 17, 2023
Merged

Fix clp constraints #1366

merged 6 commits into from
Oct 17, 2023

Conversation

jsnel
Copy link
Member

@jsnel jsnel commented Oct 17, 2023 •
edited
Loading

This fixes various issue found when running the fluorescence target analysis case study.

@jsnel jsnel requested review from s-weigand, joernweissenborn and a team as code owners October 17, 2023 19:05
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch jsnel/pyglotaran/fix_clp_constraints

@jsnel
Copy link
Member Author

jsnel commented Oct 17, 2023

Due to the nature of this branch, some checks are not expected to complete yet.

@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Attention: 156 lines in your changes are missing coverage. Please review.

Files Coverage Δ
glotaran/__init__.py 100.0% <100.0%> (ø)
glotaran/builtin/elements/baseline/__init__.py 100.0% <100.0%> (ø)
glotaran/builtin/elements/clp_guide/__init__.py 100.0% <100.0%> (ø)
glotaran/builtin/elements/clp_guide/element.py 100.0% <100.0%> (ø)
...ran/builtin/elements/coherent_artifact/__init__.py 100.0% <100.0%> (ø)
...an/builtin/elements/damped_oscillation/__init__.py 100.0% <100.0%> (ø)
glotaran/builtin/elements/kinetic/__init__.py 100.0% <100.0%> (ø)
glotaran/builtin/elements/kinetic/kinetic.py 100.0% <100.0%> (ø)
glotaran/builtin/elements/spectral/__init__.py 100.0% <100.0%> (ø)
glotaran/builtin/io/pandas/csv.py 100.0% <100.0%> (ø)
... and 54 more

... and 47 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

joernweissenborn
joernweissenborn approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@joernweissenborn joernweissenborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsnel jsnel merged commit a2211d6 into glotaran:staging Oct 17, 2023
jsnel added a commit to jsnel/pyglotaran that referenced this pull request Jun 2, 2024
@jsnel @joernweissenborn
Fix clp constraints (glotaran#1366)
3b35484 
* Resolve penalties and relations.

* Fix penalty.applies.

* In clp_penalties make source_interval and target_interval plural again

* Fix codespell config

* Fix for codeowners file

* Fix dataset scale resolve.

---------

Co-authored-by: Joern Weissenborn <joern.weissenborn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joernweissenborn joernweissenborn joernweissenborn approved these changes

@s-weigand s-weigand Awaiting requested review from s-weigand s-weigand is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsnel @joernweissenborn