Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Use clp-guide megacomplex instead of the 1x1 k-matrix workaround #106

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Jun 15, 2024

This change updates the syntax of the spectral guide example to use a clp-guide megacomplex instead of the initial workaround of a to use a decay megacomplex where the k-matrix only has a single compartment that decays to the ground state.

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

Copy link
Contributor

sourcery-ai bot commented Jun 15, 2024

🧙 Sourcery is reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes validation so 👍

@s-weigand s-weigand merged commit 5e15736 into glotaran:main Jun 15, 2024
19 checks passed
@s-weigand s-weigand deleted the clp-mc branch June 15, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants