Remove testing on the 16.x line of virtualenv #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`virtualenv` version 16.x would rewrite the `site` module, which caused some past versions of the CLI to emit errors at import time, as the simulated `site` module didn't exactly match the stdlib. 16.7.12 was a recent release of virtualenv at the time that we introduced this testing in 2021, and 16.x had releases contemporaneous with some of th earlier 20.x releases of virtualenv. However, there have been no subsequent releases in the 16.x line. Therefore, we can safely assume that support for these older versions has been dropped by virtualenv upstream, and we don't necessarily need to thoroughly test for compatibility with these versions. No compatibility code has been removed (see `_is_user_install` in `src/globus_cli/commands/update.py`), but it may not be necessary anymore.
kurtmckee
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virtualenvversion 16.x would rewrite thesitemodule, which caused some past versions of the CLI to emit errors at import time, as the simulatedsitemodule didn't exactly match the stdlib. 16.7.12 was a recent release of virtualenv at the time that we introduced this testing in 2021, and 16.x had releases contemporaneous with some of th earlier 20.x releases of virtualenv. However, there have been no subsequent releases in the 16.x line.Therefore, we can safely assume that support for these older versions has been dropped by virtualenv upstream, and we don't necessarily need to thoroughly test for compatibility with these versions.
No compatibility code has been removed (see
_is_user_installinsrc/globus_cli/commands/update.py), but it may not be necessary anymore.