Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to the reusable tox workflow #1049

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Migrate to the reusable tox workflow #1049

merged 2 commits into from
Nov 8, 2024

Conversation

kurtmckee
Copy link
Member

@kurtmckee kurtmckee commented Nov 5, 2024 •
edited
Loading

Other

  • Migrate to a reusable GitHub workflow.
  • Always recreate -sdkmain tox environments to ensure the SDK tarball is re-installed.
Metric Before this PR This PR (cache miss) This PR (cache hit)
Total duration 1m 13s 2m 57s 2m 26s
Total run time 9m 5s 5m 35s 4m 21s

@kurtmckee kurtmckee added the no-news-is-good-news This change does not require a news file label Nov 5, 2024
@kurtmckee kurtmckee self-assigned this Nov 5, 2024
@kurtmckee kurtmckee force-pushed the reusable-tox-workflow branch 5 times, most recently from 1d5c47a to 7011db5 Compare November 5, 2024 21:05
@kurtmckee kurtmckee marked this pull request as ready for review November 5, 2024 21:30
@kurtmckee kurtmckee marked this pull request as draft November 5, 2024 21:31
@kurtmckee kurtmckee force-pushed the reusable-tox-workflow branch 2 times, most recently from 40c56e7 to 3c865db Compare November 5, 2024 22:24
@kurtmckee kurtmckee marked this pull request as ready for review November 5, 2024 22:24
@kurtmckee kurtmckee force-pushed the reusable-tox-workflow branch from 3c865db to 809a095 Compare November 5, 2024 22:26
@kurtmckee kurtmckee changed the title Migrate to a reusable tox workflow Migrate to the reusable tox workflow Nov 6, 2024
sirosen
sirosen requested changes Nov 7, 2024
View reviewed changes
@kurtmckee kurtmckee force-pushed the reusable-tox-workflow branch from 809a095 to d520aae Compare November 7, 2024 16:16
@kurtmckee kurtmckee merged commit f598760 into main Nov 8, 2024
6 checks passed
@kurtmckee kurtmckee deleted the reusable-tox-workflow branch November 8, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirosen sirosen sirosen approved these changes

@aaschaer aaschaer Awaiting requested review from aaschaer aaschaer is a code owner

@ada-globus ada-globus Awaiting requested review from ada-globus ada-globus is a code owner

@derek-globus derek-globus Awaiting requested review from derek-globus derek-globus is a code owner

@m1yag1 m1yag1 Awaiting requested review from m1yag1 m1yag1 is a code owner

@MaxTueckeGlobus MaxTueckeGlobus Awaiting requested review from MaxTueckeGlobus MaxTueckeGlobus is a code owner

Assignees

@kurtmckee kurtmckee

Labels
no-news-is-good-news This change does not require a news file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kurtmckee @sirosen