Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop deleting the templated client on logout #1022

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

ada-globus
Copy link
Contributor

@ada-globus ada-globus commented Aug 17, 2024

image

Signed-off-by: Ada <ada@globus.org>
@sirosen
Copy link
Member

sirosen commented Aug 19, 2024

Does the login path not need any adjustment?

That was something I've been meaning to check, but since there's an approval on this, I want to comment before it merges.

That's my only point of concern; very happy with the new tests and so forth.

Copy link
Member

@sirosen sirosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just read down the path I was worried about -- login with no tokens in the presence of the templated client -- and it's all good. The entire codepath follows a "get-or-create" paradigm. That was my only hesitation, so I think we're good to go!

@ada-globus ada-globus merged commit 4fb5f9f into main Aug 19, 2024
32 checks passed
@ada-globus ada-globus deleted the an/stop-deleting-client-on-logout/sc-35143 branch August 19, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants