Convert to ConnectorTable for resolution #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than keeping a CLI-specific dict of IDs and names, use the ConnectorTable object provided by the SDK to resolve IDs to names. This changeset also eliminates a never-used method for converting names to IDs, which is functionality provided by the ConnectorTable if we should need it. In addition to test refactoring, the relevant test module is renamed. The changelog notes this as a rendering fix, since Dropbox and HPSS were previously missing from the data but are included in the ConnectorTable. So, effectively two entries have been "added" to this formatter.
kurtmckee
requested changes
Jul 29, 2024
Co-authored-by: Kurt McKee <contactme@kurtmckee.org>
kurtmckee
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than keeping a CLI-specific dict of IDs and names, use the
ConnectorTable object provided by the SDK to resolve IDs to names.
This changeset also eliminates a never-used method for converting
names to IDs, which is functionality provided by the ConnectorTable if
we should need it.
In addition to test refactoring, the relevant test module is renamed.
The changelog notes this as a rendering fix, since Dropbox and HPSS
were previously missing from the data but are included in the
ConnectorTable. So, effectively two entries have been "added" to this
formatter.