Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:#656 - improved cypress test #657

Merged
merged 122 commits into from
Feb 8, 2025

Conversation

sana7044
Copy link
Collaborator

@sana7044 sana7044 commented Nov 14, 2024

🛠 Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #656

✨ Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🧪 All Test Suites Passed?

  • Manual tested
  • Vitest
  • Cypress

📸 Screenshots (optional)

Please provide some screenshot for relevant changes

🏎 Quick checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@sana7044 sana7044 added Type: Enhancement Enhancement to existing feature Type: External Suggestion coming from users labels Nov 14, 2024
@sana7044 sana7044 added this to the Release 3.0 milestone Nov 14, 2024
@sana7044 sana7044 self-assigned this Nov 14, 2024
@sana7044 sana7044 marked this pull request as draft November 14, 2024 12:39
@sana7044 sana7044 requested a review from marclupanc December 7, 2024 14:24
@sana7044 sana7044 marked this pull request as ready for review December 7, 2024 14:24
@sana7044 sana7044 marked this pull request as draft December 12, 2024 15:23
Copy link

cloudflare-workers-and-pages bot commented Dec 12, 2024

Deploying celebrityfanalyzer with  Cloudflare Pages  Cloudflare Pages

Latest commit: bc5db79
Status: ✅  Deploy successful!
Preview URL: https://1c20f4a3.celebrity-fanalyzer.pages.dev
Branch Preview URL: https://656-feat-improved-cypress-te.celebrity-fanalyzer.pages.dev

View logs

@sana7044 sana7044 marked this pull request as ready for review February 5, 2025 09:21
@marclupanc marclupanc merged commit 0408bcd into develop Feb 8, 2025
5 checks passed
@marclupanc marclupanc deleted the 656-feat-improved-cypress-test-coverage branch February 8, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In progress Work in progress Type: Enhancement Enhancement to existing feature Type: External Suggestion coming from users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Improved Cypress Test Coverage
2 participants