Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:#636 - implemented profile picture upload dialog #655

Merged
merged 4 commits into from
Nov 16, 2024

Conversation

sana7044
Copy link
Collaborator

@sana7044 sana7044 commented Nov 10, 2024

🛠 Description

The user profile page previously lacked a complete interface for managing profile pictures, including options to preview, save, cancel, and delete profile pictures.

Implementation Details:

  • Upload Dialog: Added a modal dialog that opens when the user opts to upload a profile picture.
  • Image Preview: Integrated a preview area within the dialog to allow users to view the uploaded image before saving.
  • Save and Cancel Buttons: Enabled users to confirm or discard the upload with "Save" and "Cancel" buttons.
  • Delete Button: Introduced a "Delete" button for users to remove their current profile picture.

UI Enhancements:

  • Refined the dialog layout to incorporate all four actions—Upload, Preview, Save, Cancel, and Delete—for a complete user experience.
  • Improved button styling and positioning to maintain a consistent and user-friendly design.

Fixes #636

✨ Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

🧠 Rationale behind the change

--

🧪 All Test Suites Passed?

  • Manual tested
  • Vitest
  • Cypress

Testing & Validation:

  • Confirmed the dialog opens properly when uploading a profile picture and that the image preview works as expected.
  • Verified the "Save" and "Cancel" buttons function correctly, saving or discarding changes as intended.
  • Tested the "Delete" button to ensure it prompts for confirmation and successfully removes the profile picture upon confirmation.
  • Conducted cross-browser testing for consistency and compatibility.

📸 Screenshots (optional)

Screenshot from 2024-11-10 19-22-24

🏎 Quick checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@sana7044 sana7044 added Type: Enhancement Enhancement to existing feature Type: External Suggestion coming from users labels Nov 10, 2024
@sana7044 sana7044 added this to the Release 2.5 milestone Nov 10, 2024
@sana7044 sana7044 requested a review from marclupanc November 10, 2024 14:30
@sana7044 sana7044 self-assigned this Nov 10, 2024
@sana7044 sana7044 changed the title 636 feat profile picture upload dialog feat:#636 - implemented profile picture upload dialog Nov 10, 2024
@marclupanc
Copy link
Collaborator

In your descripiton you accidentally mentioned fix for other ticket :)

@marclupanc marclupanc merged commit 5b8134e into develop Nov 16, 2024
5 checks passed
@marclupanc marclupanc deleted the 636-feat-profile-picture-upload-dialog branch November 16, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Enhancement to existing feature Type: External Suggestion coming from users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] - Add Profile Picture Upload Dialog with Preview,Save, and Cancel Buttons
2 participants