Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tanstack setup. Removed layer8. Added layer8 mock. Service worker #524

Merged
merged 6 commits into from
Aug 31, 2024

Conversation

marclupanc
Copy link
Collaborator

  • Setup tanstack. Currently its just an initial setup which will be used in the future. IndexedDb setup to work with tanstack.
  • Remove layer8.interceptor
  • Added mockLayer8.interceptor
  • Added service worker to cache images

@marclupanc marclupanc added Type: Enhancement Enhancement to existing feature Difficulty: Advanced Advanced level Type: Performance Code issues that do not introduce bugs in the execution but neet performance optimisation. labels Aug 25, 2024
@marclupanc marclupanc added this to the Release 2.3 milestone Aug 25, 2024
@marclupanc marclupanc requested a review from sana7044 August 25, 2024 12:07
@marclupanc marclupanc self-assigned this Aug 25, 2024
Copy link

cloudflare-workers-and-pages bot commented Aug 25, 2024

Deploying celebrityfanalyzer with  Cloudflare Pages  Cloudflare Pages

Latest commit: eaf6a41
Status: ✅  Deploy successful!
Preview URL: https://f785cded.celebrity-fanalyzer.pages.dev
Branch Preview URL: https://feat-tanstack-implementation.celebrity-fanalyzer.pages.dev

View logs

@sana7044
Copy link
Collaborator

sana7044 commented Aug 28, 2024

There are some errors in the console when you open any prompt or advertisement .
Additionally, in the arthrogram tab, the stats data-related charts are not visible.
Screenshot 2024-08-28 at 4 50 32 PM

https://www.awesomescreenshot.com/video/30938678?key=f69ee84480109b56fd6f802022691fe8

@marclupanc
Copy link
Collaborator Author

marclupanc commented Aug 28, 2024

Yes. I forgot to mention that to fully test it you should:

  1. Clone Stats-Api repo. (https://github.com/globe-and-citizen/Stats-API)
  2. Checkout to feat/mockLayer8 branch in stats-api
  3. Run stats-api locally (npm run start)
  4. Go to stores/stats.js in Celebrity Fanalyzer and change baseUrl to http://localhost:6001/v1
  5. Go to utils/layer8init.js in CF and change statsApiUrl also to http://localhost:6001/v1
    Than it should have no errors in console and load all the stats

Because it depends one of another we have to push changes simmultaniously both in stats api and CF. Currently stats-api is still linked to development branch in CF. After merging this to development stats-api will also be updated.

@sana7044
Copy link
Collaborator

sana7044 commented Aug 29, 2024

Yes. I forgot to mention that to fully test it you should:

  1. Clone Stats-Api repo. (https://github.com/globe-and-citizen/Stats-API)
  2. Checkout to feat/mockLayer8 branch in stats-api
  3. Run stats-api locally (npm run start)
  4. Go to stores/stats.js in Celebrity Fanalyzer and change baseUrl to http://localhost:6001/v1
  5. Go to utils/layer8init.js in CF and change statsApiUrl also to http://localhost:6001/v1
    Than it should have no errors in console and load all the stats

Because it depends one of another we have to push changes simmultaniously both in stats api and CF. Currently stats-api is still linked to development branch in CF. After merging this to development stats-api will also be updated.

There is no env file in that repo

Copy link
Collaborator

@sana7044 sana7044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@marclupanc marclupanc merged commit 8374c83 into develop Aug 31, 2024
3 checks passed
@marclupanc marclupanc deleted the feat/tanstack-implementation branch August 31, 2024 08:59
@marclupanc marclupanc mentioned this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: Advanced Advanced level Type: Enhancement Enhancement to existing feature Type: Performance Code issues that do not introduce bugs in the execution but neet performance optimisation.
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants