Add Min/Max find options #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bozaro Thanks for another great PR - would you mind including a test or two to verify the behaviour and we'll be happy to merge this. Dom |
|
I added simple test for Min/Max methods. |
|
Thanks @bozaro - it's really appreciated! Dom |
szank
previously approved these changes
Jul 2, 2018
csucu
previously approved these changes
Jul 2, 2018
eminano
previously approved these changes
Jul 2, 2018
domodwyer
previously approved these changes
Jul 3, 2018
|
Hi @bozaro I changed this to point to Dom |
|
Rebased to |
domodwyer
approved these changes
Jul 4, 2018
|
Thanks for another clean PR @bozaro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add methods for set lower and upper bound for all keys of a specific index in order.