Fixup issues with dynamic angle bracket invocation. #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two different issues identified with dynamic invocation via angle brackets: * The Angle Bracket Invocation RFC specifically forbids implicit `this` lookups from being considered. Prior to the changes here `<foo.bar />` would have worked the same as `<this.foo.bar />`. These changes bring the implementation in line with the RFC. * The prior implementation did not support using a path off of a local, these changes fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two different issues identified with dynamic invocation via angle brackets:
thislookups from being considered. Prior to the changes here<foo.bar />would have worked the same as<this.foo.bar />. These changes bring the implementation in line with the RFC. Related to Angle Bracket Invocation allows implicit this with paths emberjs/ember.js#16712.