Don't rely on callerScope to yield #646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step towards first-class blocks and implementing named blocks RFC. In this PR we make sure that when we push a block onto the evaluation stack we also push the scope that the block is closing over.
A slightly longer explanation...
Prior to this PR, whenever we executed a
{{yield}}
inside a component, we assumed that the scope that the block closed over was the same scope that invoked the component itself.In fact at the moment this is always true because there is no way to
{{yield}}
to a block other than the ones that were syntactically part of the component invocation.With first-class blocks this changes. First-class blocks means that blocks are values and can be passed around as such. See named blocks RFC for more deatils, but long story short, this means that it is no longer safe to assume that the block's scope is the same as the caller's scope. For example,
In this setup we'd expect the output to be