Allow loose mode to use lexical scope

glimmerjs · Oct 21, 2021 · 5ea7772 · 5ea7772
1 parent 8a81d94
commit 5ea7772
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/packages/@glimmer/integration-tests/test/lexical-scope-test.ts b/packages/@glimmer/integration-tests/test/lexical-scope-test.ts
@@ -0,0 +1,17 @@
+import { RenderTest, test, jitSuite, defineComponent } from '..';
+
+class LexicalScopeTest extends RenderTest {
+  static suiteName = 'loose mode: lexical scope';
+
+  @test
+  'Can use a component in scope'() {
+    const Foo = defineComponent({}, 'Hello, world!', { strictMode: false });
+    const Bar = defineComponent({ Foo }, '<Foo/>', { strictMode: false });
+
+    this.renderComponent(Bar);
+    this.assertHTML('Hello, world!');
+    this.assertStableRerender();
+  }
+}
+
+jitSuite(LexicalScopeTest);
diff --git a/packages/@glimmer/syntax/lib/v2-a/normalize.ts b/packages/@glimmer/syntax/lib/v2-a/normalize.ts
@@ -40,7 +40,7 @@ export function normalize(
   );
 
   let top = SymbolTable.top(
-    normalizeOptions.strictMode ? normalizeOptions.locals : [],
+    normalizeOptions.locals,
     // eslint-disable-next-line @typescript-eslint/unbound-method
     options.customizeComponentName ?? ((name) => name)
   );