Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement termPenaltyOnPledge() method #84

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Implement termPenaltyOnPledge() method #84

wants to merge 5 commits into from

Conversation

jimpick
Copy link
Collaborator

@jimpick jimpick commented Jul 9, 2024

This will calculate the termination penalty for a quantity of FIL that is used to pledge sectors.

Unit test:

go test ./terminate/onpledge*.go

@jimpick jimpick requested a review from Schwartz10 July 9, 2024 05:12
Schwartz10
Schwartz10 reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@Schwartz10 Schwartz10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really clean - great work on this. Only comment is about the hardcoded values for activation and expiration - can we instead use ts for activation and then 18 months of epochs added to the expiration?

terminate/onpledge.go Outdated Show resolved Hide resolved
@jimpick jimpick mentioned this pull request Jul 18, 2024
Closed
@jimpick
New TermPenaltyOnPledge() func with some hardcoded values
0abb856 
Get ExpectedDayReward using go-state-types

Compute verified deal weight

Calculate cost and penalty
@jimpick jimpick force-pushed the jim_term_penalty_on_pledge branch from 9e904fd to 0abb856 Compare November 14, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schwartz10 Schwartz10 Schwartz10 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimpick @Schwartz10