Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing liquidation value #65

Merged
merged 10 commits into from
Jun 28, 2024
Merged

Testing liquidation value #65

merged 10 commits into from
Jun 28, 2024

Conversation

Schwartz10
Copy link
Contributor

No description provided.

@Schwartz10
Copy link
Contributor Author

@jimpick it would be super helpful if you could take this one across the finish line, there are a few things left to tackle:

  1. We should run this test on say 10 miners in parallel rather than just 1 miner. I couldn't get the precise method to play nicely in parallel with the various channels and inside the test runner.
  2. We should make sure that each miner that gets tested has active sectors (rather than just the one we're choosing)
  3. We should double check the accuracy of the AssertApproxEqRel func (i wrote tests, but it would be nice to get more confidence)

@jimpick jimpick merged commit cc66b24 into main Jun 28, 2024
@jimpick jimpick deleted the testing-liquidation-value branch June 28, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants