Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add navigation icons #62

Merged
merged 5 commits into from
Jan 13, 2022
Merged

feat: add navigation icons #62

merged 5 commits into from
Jan 13, 2022

Conversation

joshuajames-smith
Copy link
Contributor

@joshuajames-smith joshuajames-smith commented Jan 12, 2022

Description

Adding 4 icons required for navigation rethink design - uploading .svg files and including in icons.ts to appear in staging. These icons should allow for a better UX of the navigation flow! They use icons to represent the product/platform and use arrow as a visual clue towards navigation processes.

Don't forget to reference all other pull requests which are associated to this one below: e.g.

relates gliff-ai/dominate#306

Documentation (delete if not applicable)

@philhallbio will need to update documentation once gliff-ai/dominate#306 has been fully implemented.

Checklist:

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request). If you're unsure about any of these, don't hesitate to leave a comment on this pull request!

  • I have read the gliff.ai Contribution Guide.
  • I have requested to pull a branch and not from main.
  • I have checked all commit message styles match the requested structure.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my own code.
  • I have assigned 3 or less reviewers.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes generate no new warnings.
  • I have made corresponding changes to the documentation.
  • New database changes have been committed.
  • If appropriate, I have bumped any version numbers.

@joshuajames-smith joshuajames-smith added the feature [Improvement] New feature request. label Jan 12, 2022
@joshuajames-smith joshuajames-smith self-assigned this Jan 12, 2022
@joshuajames-smith joshuajames-smith marked this pull request as ready for review January 12, 2022 15:56
@mergify mergify bot merged commit 6b032ef into main Jan 13, 2022
@mergify mergify bot deleted the addNAVIGATIONicons branch January 13, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature [Improvement] New feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants