Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team names #133

Merged
merged 3 commits into from
Oct 14, 2021
Merged

Team names #133

merged 3 commits into from
Oct 14, 2021

Conversation

ChasNelson1990
Copy link
Member

Description

Patch: Fixes a typo'ed filename and incorrect migration dependency - @cooper667, we can choose to ignore this commit if this is going to cause lots of deploy issues, which I suspect it might.

Minor: Add name to Teams model and updates the only create call and the out schema for returning team info. We might like to add the team name to user profile outputs too but that can be done when we actually use the team name.

closes #132
relates gliff-ai/dominate#306

Dependency changes

None

Has the pipfile.lock or package-lock.json been updated? No

Testing

None (except pydantic schema checks)

Documentation

Please describe the new documentation that has been added for this change? None

Migrations (if applicable)

Yes, two. One manually patched. One automatically generated.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New migrations have been committed
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If appropriate, I have bumped any version numbers

@ChasNelson1990 ChasNelson1990 self-assigned this Oct 14, 2021
@ChasNelson1990 ChasNelson1990 added the enhancement [Improvement] Enhancement request. label Oct 14, 2021
Copy link
Contributor

@cooper667 cooper667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the migration will be fine

@ChasNelson1990 ChasNelson1990 merged commit 2a87afc into staging Oct 14, 2021
@ChasNelson1990 ChasNelson1990 deleted the teamNames branch October 14, 2021 13:12
@ChasNelson1990
Copy link
Member Author

Think the migration will be fine

Let's find out!

ChasNelson1990 added a commit that referenced this pull request Oct 27, 2021
* feat: reduce tier free storage (#131)

* Team names (#133)

* fix: correct filename and dependency for migration

* feat: add name to Team model

* chore: bump version number

* fix: change checkout session to be allowed

* feat: Custom Plans (#139)

* feat: custom plans

* fix: tidy responses

Co-authored-by: Craig Cooper <c@c9r.dev>
ChasNelson1990 added a commit that referenced this pull request Nov 4, 2021
* feat: reduce tier free storage (#131)

* Team names (#133)

* fix: correct filename and dependency for migration

* feat: add name to Team model

* chore: bump version number

* fix: change checkout session to be allowed

* feat: Custom Plans (#139)

* feat: custom plans

* fix: tidy responses

Co-authored-by: Craig Cooper <c@c9r.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [Improvement] Enhancement request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the option for team names
4 participants