-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: centred and styled productsNavbar #585
Conversation
Conditionally rendered productSection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on getting this together, it all appears to work for me!
I just have a couple styling changes:
- Could we make the devider lines (marked by the red box) reach the top and bottom?
- Could we add some more space between the centre text and these divider lines?
- The text is currently in all caps, could we have this set as normal?
Also a question. I'm sure not if this is in another pr/issue, but we have lost the current product
view and help
button?
Finally just a side note, I know we have plans to remove this page from shown via a redirect (#595) but just to note the navbar element exists here!
Returned text to camelCase
Also seems true for the other icons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good and the issue with the icons is fixed. I got a couple changes for this PR:
- In AUDIT there is just the team name. Can we use project name and then project name > image name for each of the two AUDIT views? i.e. use CURATE and ANNOTATE content.
@Kinukeo wanna solve the conflicts before I review? Otherwise I'll just have to review again? |
All requested changes have been resolved
Just to note, this was because this staging account was veeery old and did not have a team name. All new team's now get a team name by default so this is not actually an issue. |
Description
Buttons on the navbar will now change depending on which wrapper is selected, these buttons also now allow the user to navigate to other wrappers.
relates #306
Checklist:
Put an
x
in the boxes that apply to this pull request (you can also fill these out after opening the pull request). If you're unsure about any of these, don't hesitate to leave a comment on this pull request!