feat!: Added imageData to productsNavbar #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-pebble-068ecb003-176.westeurope.azurestaticapps.net |
SilviaZeta
reviewed
Apr 4, 2022
src/components/ProjectAuditTable.tsx
Outdated
| @@ -24,6 +24,7 @@ interface Props { | |||
| searchField: string; | |||
| searchValue: string; | |||
| setAudit: (audit: AuditAction[]) => void; | |||
| setProductsNavbarImageData: (imageName: ImageData) => void; | |||
There was a problem hiding this comment.
Make this prop optional and set a default or change the PR's title to "feat!: Added..." to make it a breaking change?
SilviaZeta
suggested changes
Apr 4, 2022
src/components/ProjectAuditTable.tsx
Outdated
| @@ -24,6 +24,7 @@ interface Props { | |||
| searchField: string; | |||
| searchValue: string; | |||
| setAudit: (audit: AuditAction[]) => void; | |||
| setProductsNavbarImageData: (imageName: ImageData) => void; | |||
There was a problem hiding this comment.
and perhaps rename imageName as imageData?
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-pebble-068ecb003-176.westeurope.azurestaticapps.net |
SilviaZeta
approved these changes
Apr 11, 2022
ChasNelson1990
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added imageName and imageUid to annotation session in order to allow dominate to request this information and display them in the productsNavbar
Don't forget to reference all other pull requests which are associated to this one below: e.g.
relates gliff-ai/dominate#306
Checklist:
Put an
xin the boxes that apply to this pull request (you can also fill these out after opening the pull request). If you're unsure about any of these, don't hesitate to leave a comment on this pull request!