Remove rgbchannels and MetadataOnly blocks #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
RGB data is only written if exactly 3 channels exist and there are no Z sections or timepoints. The Z/T restriction could be removed once full multi-dimensional support is added.
|
|
This was referenced Apr 26, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrects https://github.com/glencoesoftware/raw2ometiff/compare/master...chris-allan:fix-legacy?expand=1 with conflicts fixed. Replaces #19, and requires glencoesoftware/isyntax2raw#15.
Running the full conversion against both iSyntax files and something like
bf-data-repo/automated-tests/curated/jpeg/big-images/8kx8k.jpgshould result in a readable OME-TIFF with multiple channels (and no errors).