Add key-values format to data task #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
reviewed
Nov 26, 2021
| @@ -85,6 +85,8 @@ def print_forest(forest, opts, version = :show_tree) | |||
| puts forest.inspect | |||
| when 'keys' | |||
| puts forest.key_names(root: true) | |||
| when 'key-values' | |||
| puts forest.key_values(root: true).map { |kv| kv.join(' ') } | |||
There was a problem hiding this comment.
The key can contain spaces so perhaps it's better join with a \t?
There was a problem hiding this comment.
Good point, although wouldn't it make more sence to use a colon?
There was a problem hiding this comment.
A colon can also be part of the key name
There was a problem hiding this comment.
Okay, I'll make it a \t. Couldn't that also be a part of the key name though? As far as I can tell every character is allowed as long as it's properly escaped.
There was a problem hiding this comment.
True but \t is unlikely whereas I've seen : and in the bug reports here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.