Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-509: new inv_triangle_number popped up in another PR #528

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

Saransh-cpp
Copy link
Member

Description

My bad. #523 introduced some occurrences of inv_triangle_number which went unnoticed. Prime example of why you should make your PRs "up-to-date" before merging.

Refs: #509

Changelog entry

Checks

  • Is your code passing linting?
  • Is your code passing tests?
  • Have you added additional tests (if required)?
  • Have you modified/extended the documentation (if required)?
  • Have you added a one-liner changelog entry above (if required)?

@Saransh-cpp Saransh-cpp added bug Something isn't working maintenance Maintenance: refactoring, typos, etc. labels Feb 21, 2025
@Saransh-cpp Saransh-cpp added this to the v2025.1 milestone Feb 21, 2025
@Saransh-cpp Saransh-cpp self-assigned this Feb 21, 2025
@Saransh-cpp Saransh-cpp marked this pull request as ready for review February 21, 2025 15:02
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lesson learned, it's a useful feature!

@paddyroddy paddyroddy merged commit c7635f8 into main Feb 21, 2025
24 checks passed
@paddyroddy paddyroddy deleted the saransh/fix-tests branch February 21, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Maintenance: refactoring, typos, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants