Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-513: make algorithm a public module #514

Merged
merged 7 commits into from
Feb 19, 2025
Merged

gh-513: make algorithm a public module #514

merged 7 commits into from
Feb 19, 2025

Conversation

ntessore
Copy link
Collaborator

Move glass.core.algorithm to glass.algorithm and document it for public use outside of GLASS itself.

Closes: #513

@ntessore ntessore added this to the v2025.1 milestone Feb 18, 2025
@Saransh-cpp Saransh-cpp marked this pull request as ready for review February 19, 2025 12:12
@Saransh-cpp Saransh-cpp marked this pull request as draft February 19, 2025 12:12
@Saransh-cpp Saransh-cpp marked this pull request as ready for review February 19, 2025 12:19
paddyroddy
paddyroddy requested changes Feb 19, 2025
View reviewed changes
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you look at docs/reference/fields.rst?

@Saransh-cpp
Copy link
Member

Ah, missed that, thanks!

paddyroddy
paddyroddy approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 core

@Saransh-cpp Saransh-cpp added maintenance Maintenance: refactoring, typos, etc. api An (incompatible) API change labels Feb 19, 2025
@Saransh-cpp Saransh-cpp merged commit 9120291 into main Feb 19, 2025
18 checks passed
@Saransh-cpp Saransh-cpp deleted the nt/513 branch February 19, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paddyroddy paddyroddy paddyroddy approved these changes

@Saransh-cpp Saransh-cpp Saransh-cpp approved these changes

Assignees

@Saransh-cpp Saransh-cpp

Labels
api An (incompatible) API change maintenance Maintenance: refactoring, typos, etc.
Projects
None yet
Milestone
v2025.1
Development

Successfully merging this pull request may close these issues.

Turn algorithms into public module
3 participants
@ntessore @Saransh-cpp @paddyroddy