Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-499: rm D205, D401, EM101, EM102, TRY003 #510

Merged
merged 1 commit into from
Feb 13, 2025
Merged

gh-499: rm D205, D401, EM101, EM102, TRY003 #510

merged 1 commit into from
Feb 13, 2025

Conversation

Saransh-cpp
Copy link
Member

Description

Removes D205, D401, EM101, EM102, TRY003, as agreed in the issue discussion.

Closes: #499

Changelog entry

Checks

  • Is your code passing linting?
  • Is your code passing tests?
  • Have you added additional tests (if required)?
  • Have you modified/extended the documentation (if required)?
  • Have you added a one-liner changelog entry above (if required)?

@Saransh-cpp Saransh-cpp self-assigned this Feb 13, 2025
paddyroddy
paddyroddy approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Saransh-cpp Saransh-cpp requested a review from ntessore February 13, 2025 18:01
@Saransh-cpp Saransh-cpp added the maintenance Maintenance: refactoring, typos, etc. label Feb 13, 2025
ntessore
ntessore approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@ntessore ntessore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Saransh-cpp Saransh-cpp merged commit d384a83 into main Feb 13, 2025
17 checks passed
@Saransh-cpp Saransh-cpp deleted the saransh/linters branch February 13, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntessore ntessore ntessore approved these changes

@paddyroddy paddyroddy paddyroddy approved these changes

Assignees

@Saransh-cpp Saransh-cpp

Labels
maintenance Maintenance: refactoring, typos, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make linter less invasive
3 participants
@Saransh-cpp @ntessore @paddyroddy