Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-469: @pre-commit.ci shouldn't break title checking #474

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

paddyroddy
Copy link
Member

@paddyroddy paddyroddy commented Jan 13, 2025

Fixes #469. In #467 the title workflow was successfully skipped, but then I made a change and it failed. The check should be changed for the PR author instead using github.event.pull_request.user.login.

@paddyroddy paddyroddy added bug Something isn't working infrastructure Project infrastructure: dev tools, packaging, etc. labels Jan 13, 2025
@paddyroddy paddyroddy self-assigned this Jan 13, 2025
@paddyroddy paddyroddy changed the title pre-commit.ci: update pre-commit hooks gh-469: @pre-commit.ci shouldn't break title checking Jan 13, 2025
Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @paddyroddy!

@paddyroddy paddyroddy merged commit 8521dde into main Jan 17, 2025
6 of 11 checks passed
@paddyroddy paddyroddy deleted the paddy/issue-469 branch January 17, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infrastructure Project infrastructure: dev tools, packaging, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR title failing for pre-commit bot
2 participants