-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename glass.core.array
to glass.arraytools
#478
Comments
Do we care? |
@ntessore it's an up-to-you situation. It could cause unwanted issues https://docs.astral.sh/ruff/rules/stdlib-module-shadowing, but if you want to keep it then please close this issue. |
I realise that it could cause issues in general, but I can vouch for the fact that we are not going to use the stdlib |
That said, if we don't want to override the rule on a case-by-case basis, we can also rename that module to something else. I really don't care! |
This can definitely create problems. I'd suggest renaming the module to Let me know which one sounds good and I can create a PR! |
If |
That makes sense. |
A005
Module array
shadows a Python standard-library moduleglass.core.array
to glass.arraytools
Describe the Bug
Picked up by
ruff==0.9.1
in #477. For now I have suppressed with# noqa: A005
.To Reproduce
Expected Behaviour
No response
Actual Behaviour
No response
Version In Use
2024.3.dev32+g0b41f16
Additional Context
The text was updated successfully, but these errors were encountered: