Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Issue class #71

Merged
merged 6 commits into from
Aug 18, 2014
Merged

Create Issue class #71

merged 6 commits into from
Aug 18, 2014

Conversation

doktorbro
Copy link

WIP

With the Issue class we can sort issues by path or description. We should provide an option order (path or description). Sorting by description can help identify same issue in different files. For example a missing alt attribute in the footer on every page.

@doktorbro
Copy link
Author

I can’t figure out, why it fails at

works for array of links (FAILED - 1)

@gjtorikian
Copy link
Owner

I was interested in helping out with this one but for some reason I get way more errors than you or Travis:

Finished in 15.15 seconds
60 examples, 30 failures

'/proofer/checkable',
'/proofer/checks',
'/proofer/issue'
].each { |r| require File.dirname(__FILE__) + r }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOC, why not

[
  'checkable',
  'checks',
  'issue'
].each { |c| require File.join(File.dirname(__FILE__), 'proofer', c) }

?

@doktorbro
Copy link
Author

@parkr I followed your suggestions. Thank you.

@doktorbro
Copy link
Author

@gjtorikian I get the same error as Travis.

@doktorbro
Copy link
Author

I found the solution. All tests pass now.

@gjtorikian
Copy link
Owner

This is looking good. I'm loving the cleanup.

@gjtorikian
Copy link
Owner

I like this a lot. Does something more need to be done before a merge?

@doktorbro
Copy link
Author

Does something more need to be done before a merge?

No.

@gjtorikian
Copy link
Owner

Well, besides the new merge conflict. 😉

@doktorbro
Copy link
Author

The conflicts are resolved. Please take a look at the color methods. I hope I didn’t break the most recent changes.

@gjtorikian
Copy link
Owner

I shall!

@gjtorikian gjtorikian merged commit d3761cf into gjtorikian:master Aug 18, 2014
@doktorbro doktorbro deleted the issue-class branch August 18, 2014 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants