-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Issue class #71
Conversation
I can’t figure out, why it fails at
|
I was interested in helping out with this one but for some reason I get way more errors than you or Travis:
|
'/proofer/checkable', | ||
'/proofer/checks', | ||
'/proofer/issue' | ||
].each { |r| require File.dirname(__FILE__) + r } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OOC, why not
[
'checkable',
'checks',
'issue'
].each { |c| require File.join(File.dirname(__FILE__), 'proofer', c) }
?
@parkr I followed your suggestions. Thank you. |
@gjtorikian I get the same error as Travis. |
I found the solution. All tests pass now. |
This is looking good. I'm loving the cleanup. |
I like this a lot. Does something more need to be done before a merge? |
No. |
Well, besides the new merge conflict. 😉 |
The conflicts are resolved. Please take a look at the color methods. I hope I didn’t break the most recent changes. |
I shall! |
WIP
With the Issue class we can sort issues by path or description. We should provide an option
order
(path or description). Sorting by description can help identify same issue in different files. For example a missing alt attribute in the footer on every page.