Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow accessing list of issues directly #538

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Allow accessing list of issues directly #538

merged 1 commit into from
Sep 25, 2019

Conversation

muan
Copy link
Contributor

@muan muan commented Sep 25, 2019

👋 This pull request adds a reader for @failures so users can access them directly, and use the Issue to construct their report if they wish to do so, like what #523 wanted to do.

In our use case, we mostly want to avoid Proofer from raising a generic RuntimeError, and so we will be printing out the errors ourselves. I initially accessed #failed_tests for this, but found that we'd want to group results with path. Since #failed_test gives us issue.to_s, we will have to manually parse it back. Having #failures would be more convenient and gives developers flexibility around reporting.

It'd also be good to decouple the checks in #run into another method so it can be called without raise/logger. I thought I'd start small for now. Thoughts?

cc @gjtorikian 😬

@muan muan requested a review from Floppy as a code owner September 25, 2019 15:16
@codecov-io
Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #538 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #538      +/-   ##
==========================================
+ Coverage    98.6%   98.61%   +<.01%     
==========================================
  Files          30       30              
  Lines        1935     1943       +8     
==========================================
+ Hits         1908     1916       +8     
  Misses         27       27
Impacted Files Coverage Δ
spec/html-proofer/proofer_spec.rb 100% <100%> (ø) ⬆️
lib/html-proofer/runner.rb 99.05% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 286f1fd...54a7aa6. Read the comment docs.

@gjtorikian
Copy link
Owner

Sure, this works for me. I'll release this as a new minor version of the library soon. Thanks!

@gjtorikian gjtorikian merged commit eedc0ad into gjtorikian:master Sep 25, 2019
@muan muan deleted the issue branch September 26, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants