Allow accessing list of issues directly #538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 This pull request adds a reader for
@failures
so users can access them directly, and use theIssue
to construct their report if they wish to do so, like what #523 wanted to do.In our use case, we mostly want to avoid Proofer from raising a generic
RuntimeError
, and so we will be printing out the errors ourselves. I initially accessed#failed_tests
for this, but found that we'd want to group results with path. Since#failed_test
gives usissue.to_s
, we will have to manually parse it back. Having#failures
would be more convenient and gives developers flexibility around reporting.It'd also be good to decouple the checks in
#run
into another method so it can be called without raise/logger. I thought I'd start small for now. Thoughts?cc @gjtorikian 😬