Specs for permanent redirect warnings #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the implementation is done. Let’s discuss it. |
|
I support the idea. I am about to head to vacation so I cannot really devote time to this at the moment, but will get to it as soon as I can! |
| @@ -39,6 +43,12 @@ def run | |||
| self.add_issue "internally linking to #{link.href}, which does not exist" unless link.exists? | |||
| end | |||
|
|
|||
| # has the local directory a trailing slash? | |||
| if !@options[:followlocation] and !link.remote? and link.unslashed_directory? | |||
| self.add_issue("linking to a directory #{link.absolute_path} without trailing slash") | |||
There was a problem hiding this comment.
I know it's trivial but can you add the word "internal" in here somewhere? Like:
"internally linking to a directory #{link.absolute_path} without trailing slash"
|
Made some comments, and don't forget to merge |
added 6 commits
July 20, 2014 09:48
Add fixture for internal redirection Add spec for internal permanent redirections Fix end Add warn_redirect option Rename option Increase readability Fix the hash Add options to the test Put the disappeared test back Put the wrong apostrophe back Simplify the internal test Rename the option Implement external check Put back a whitespace Use followlocation Remove permanent_redirection Add a test for not following redirects Use should_not Add expand path Fix coding and wording Speed up Nokogiri installation Fix expand_path Fix expand_path Ruby-duby Ruby-duby-duby Remove expand path Next if no html returns It’s path Try no href Show the path Puts path Don’t put path Don’t change the Proofer class Implement it Fix conditional It’s a link Downcase Refactor Rename fixture Fix fixture name Add path to error message
|
Changed and rebased |
gjtorikian
added a commit
that referenced
this pull request
Jul 20, 2014
Specs for permanent redirect warnings
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft for #48.