Properly ignore alt without ignoring image #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* alt_ignore for an image does not ignore the whole image now. If it is missing, it will be reported. * Also, this unearthed another issue, where srcset was not properly 'fixed' by prefixing it with http://.
|
By the way, srcset is not properly handled (as far as I can see). srcset can actually have multiple strings, separated by a comma. Ideally, each should be separately checked. Currently, the assumption seems to be that srcset is just like src. So, I've left it like that, and have only corrected the prefixing to match href and src. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just so it is clear, without this change, any image that was alt_ignored-d, was ignored here in the checking process, and so, if the image it referred to is missing, the issue wouldn't be added to the final result.