-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty hash in URL #255
Comments
I agree: #118 :) Maybe it's time to ignore this by default? |
Sorry, I did not found #118. Yes, default values should be friendly. |
How do you both feel about an implementation of #254 (that is, |
#254 is something different. Jan Pobořil 2015-11-03 19:30 GMT-06:00 Garen Torikian notifications@github.com:
|
Yeah, I agree, that's something different. |
In other words, Jan Pobořil 2015-11-03 19:58 GMT-06:00 Alexander Köplinger notifications@github.com:
|
My problem with Although I understand that ignoring Given that it's a common request, though, would not using |
That'd work for me. |
Fixes gjtorikian#255 by adding a more intuitive option to allow the `href` `#`. This option, `--allow-hash-href`, is equivalent to `--href-ignore '#'`. Its Ruby option is `allow_hash_href`, which should be a boolean and defaults to `false`.
Should be
<a href="#">
really be reported as a non-existing hash?It is often used for resetting hash in sites where hash is used to some changes in content, e.g. tabs and AJAX-loaded content.
Workaround is this parameter:
--allow-hash-href
The text was updated successfully, but these errors were encountered: