Merge pull request #486 from gjtorikian/support-unicode-domain

Support/test unicode/punnycode domains
gjtorikian · Aug 2, 2018 · 1acf204 · 1acf204
2 parents 06710dd + 431b2c0
commit 1acf204
Show file tree

Hide file tree

Showing 5 changed files with 216 additions and 0 deletions.
diff --git a/spec/html-proofer/fixtures/links/punnycode.html b/spec/html-proofer/fixtures/links/punnycode.html
@@ -0,0 +1,7 @@
+<html>
+
+<body>
+
+<p><a href="http://www.xn--mxaaaiil1bdgepgr1bpt0d.gr/">A real link</a></p>
+
+</html>
diff --git a/spec/html-proofer/fixtures/links/unicode_domain.html b/spec/html-proofer/fixtures/links/unicode_domain.html
@@ -0,0 +1,7 @@
+<html>
+
+<body>
+
+<p><a href="http://αναπτυξηεφαρμογων.gr">A real link</a></p>
+
+</html>
diff --git a/spec/html-proofer/fixtures/vcr_cassettes/links/punnycode_html_log_level_error_type_file_.yml b/spec/html-proofer/fixtures/vcr_cassettes/links/punnycode_html_log_level_error_type_file_.yml
diff --git a/...l-proofer/fixtures/vcr_cassettes/links/unicode_domain_html_log_level_error_type_file_.yml b/...l-proofer/fixtures/vcr_cassettes/links/unicode_domain_html_log_level_error_type_file_.yml
diff --git a/spec/html-proofer/links_spec.rb b/spec/html-proofer/links_spec.rb
@@ -352,6 +352,18 @@
     expect(proofer.failed_tests.length).to eq 1
   end
 
+  it 'allows unicode domains' do
+    fixture = "#{FIXTURES_DIR}/links/unicode_domain.html"
+    proofer = run_proofer(fixture, :file)
+    expect(proofer.failed_tests).to eq []
+  end
+
+  it 'allows punnycode domains' do
+    fixture = "#{FIXTURES_DIR}/links/punnycode.html"
+    proofer = run_proofer(fixture, :file)
+    expect(proofer.failed_tests).to eq []
+  end
+
   it 'passes for broken *nix links' do
     fixture = "#{FIXTURES_DIR}/links/broken_unix_links.html"
     proofer = run_proofer(fixture, :file)