Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Avoid telling developers on fedora to update their system #230

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

laine-hallot
Copy link
Contributor

@laine-hallot laine-hallot commented Jan 6, 2025

Description

Currently the development instructions tell fedora users to run sudo dnf update before installing the required development packages. Considering the sudo apt-get update instruction in the ubuntu guide I'm assuming the intent with that instruction was to make sure people's package managers have an up to date list of available packages but dnf update doesn't do that, it just updates all packages on the system.

dnf usually takes care of refreshing its cache of package metadata on its own so the fedora instructions should be fine with just sudo dnf install ...

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Type definition update
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have updated the documentation accordingly

Copy link
Collaborator

@JumpLink JumpLink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's better, thank you.

@JumpLink JumpLink merged commit 5ea66da into gjsify:main Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants