Add missing actor
member on PopupMenu
#30
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PopupMenu
class has anactor
member of typeBoxPointer
that's used when setting up a menu for a panel indicator. It's defined here: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/ui/popupMenu.js?#L879An example of this member being accessed from outside the class can be found here: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/gdm/loginDialog.js#L337
When implementing a menu for an indicator, you would do something like this:
Without this addition you have to resort to
(this as any).actor
in order to add the menu touiGroup
and hide it appropriately without type errors.From the shell code, it doesn't seem like it's ever modified from the outside, so I've made it
readonly
.EDIT: I've added the missing
actor
member toPopupDummyMenu
andPopupMenuSection
as well.