Remove redundant width and height

[swsnr]

These are already declared by Clutter.Actor, and our declarations are conflicting because they omit null.

Fixes the following compiler errors:

node_modules/.pnpm/@girs+gnome-shell@46.0.0-beta4/node_modules/@girs/gnome-shell/dist/ui/lightbox.d.ts:49:22 - error TS2320: Interface 'ConstructorProperties' cannot simultaneously extend types 'ConstructorProperties' and 'LightboxAdditionalParameters'.
  Named property 'height' of types 'ConstructorProperties' and 'LightboxAdditionalParameters' are not identical.

49     export interface ConstructorProperties extends St.Bin.ConstructorProperties, LightboxAdditionalParameters {
                        ~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/@girs+gnome-shell@46.0.0-beta4/node_modules/@girs/gnome-shell/dist/ui/lightbox.d.ts:49:22 - error TS2320: Interface 'ConstructorProperties' cannot simultaneously extend types 'ConstructorProperties' and 'LightboxAdditionalParameters'.
  Named property 'width' of types 'ConstructorProperties' and 'LightboxAdditionalParameters' are not identical.

49     export interface ConstructorProperties extends St.Bin.ConstructorProperties, LightboxAdditionalParameters {
                        ~~~~~~~~~~~~~~~~~~~~~


Found 2 errors.

[swsnr]

/cc @Totto16

[swsnr]

@JumpLink I wonder why CI didn't catch these… libcheck flagged them in my extension, and VSCode immediately flagged them too when I opened the file 🤔

[Totto16]

That might be a mess-up by me, true, it's strange, that they are not detected by the CI 🤔 (and by me locally they weren't either)
Only when using the submitted types to npm in the extension itself, the issue is shown, I'll investigate this, and merge this after I know all the details for this 👍🏼

[Totto16]

@JumpLink I wonder why CI didn't catch these… libcheck flagged them in my extension, and VSCode immediately flagged them too when I opened the file 🤔

After some investigation, it never throws and error in any scenario for me locally, I did a full reset, and also than, it never failed.

I tested e.g.

export const u: St.Bin.ConstructorProperties

type U = typeof u.height

and U was number not number| null

But in @girs/clutter-14/clutter-14.d.ts::4968 it says indeed:

height?: number | null

validating in the CI / locally just uses tsc --noEmit and maybe the reason for not throwing an error is the lack of the strict
option in the tsconfig.json.

Anyway, it seems rather complicated, can you post your setup for the configuration, you get the error (I saw you using pnpm, I don't know if thats important or not... 🤔 (it shouldn't but who knows) )
So bundler, tsconfig.

And if you run yarn build (or just yarn validate if you already have built the types into ./packages/gnome-shell/dist/) locally, do you get an error or not 🤔

[Totto16]

It really seems to be the tsconfig options, I set them to be:

{
	"compilerOptions": {
		"lib": ["ESNext"],
		"types": [],
		"target": "ESNext",
		"module": "ESNext",
		"moduleResolution": "Bundler",
		"strict": true,
		"noImplicitAny": true,
		"strictNullChecks": true,
		"noImplicitThis": true,
		"alwaysStrict": true,
		"strictPropertyInitialization": true,
		"allowSyntheticDefaultImports": true
	},
	"include": ["./dist/**/*.d.ts"],
	"files": ["./dist/index.d.ts"]
}

And than it fails 😂

Locally in the extension, I tested it on too, it has this config:

...
 "strict": true,
    "noImplicitAny": false,
    "strictNullChecks": true,
    "noImplicitThis": true,
    "alwaysStrict": true,
    "strictPropertyInitialization": false,
    "allowSyntheticDefaultImports": true,
...

strictNullChecks seems to be the root cause, even in my local extension it seems on, it doesn't get detected 🤔

[swsnr]

I didn't notice that this repo didn't set strictNullChecks and strict in its tsconfig. I think that should be corrected, i.e. these flags should be added. Ideally, the tsconfig in this repo would inherit from @tsconfig/strictest for recommended strict compiler settings, to make sure that these types are internally consistent.

As for why it doesn't fail for your extension, I presume you have libCheck disabled which will make typescript ignore all errors from library code.

[Totto16]

I didn't notice that this repo didn't set strictNullChecks and strict in its tsconfig. I think that should be corrected, i.e. these flags should be added. Ideally, the tsconfig in this repo would inherit from tsconfig:strictest.

As for why it doesn't fail for your extension, I presume you have libCheck disabled which will make typescript ignore all errors from library code.

ah yes, libCheck 🤦🏼‍♂️

[Totto16]

Fixes the previously undiscovered bug 👍🏼

[Totto16]

@JumpLink I already bumped the version, you only need to publish the version to npm ❤️

[swsnr]

@JumpLink Would you push a new version with this change?

[JumpLink]

@Totto16 , @swsnr I can also invite you to NPM, then you can do it yourself and don't have to wait for me

[JumpLink]

Is now published on NPM 👍

[Totto16]

That would work too 👍🏼
My username on npm would be totto16

[swsnr]

@JumpLink I'm confused; I see a version on NPM but no release here? Did you forget to push a tag perchance?

[swsnr]

@JumpLink As for npm, I don't have an NPM account. I'll create one, but may take a few days as I'm away now.

[JumpLink]

@swsnr Yes I forgot to draft a new release here on GitHub, did this now: https://github.com/gjsify/gnome-shell/releases/tag/46.0.0-beta5

[swsnr]

@JumpLink I finally got around to making an account on npm.js: https://www.npmjs.com/~swsnr

Sorry for the delay, easter's always pretty busy 😇

[JumpLink]

@swsnr No problem, for me too :) I have sent you an invite